Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new APIs to read EC public and private keys from files #535

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented Dec 11, 2023

Purpose

Fixes: ballerina-platform/ballerina-library#5871

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (aba11e5) 87.52% compared to head (12b4109) 87.21%.

Files Patch % Lines
.../io/ballerina/stdlib/crypto/nativeimpl/Decode.java 78.94% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #535      +/-   ##
============================================
- Coverage     87.52%   87.21%   -0.32%     
- Complexity       93       97       +4     
============================================
  Files            16       16              
  Lines           465      485      +20     
  Branches         65       69       +4     
============================================
+ Hits            407      423      +16     
- Misses           47       50       +3     
- Partials         11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Bhashinee Bhashinee merged commit 310a9cf into ballerina-platform:master Dec 12, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decodes the EC public key from the given public certificate file.
2 participants